Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix premerge cpu test python version issue #551

Closed
yiheng-wang-nv opened this issue Jan 25, 2024 · 0 comments · Fixed by #552
Closed

Fix premerge cpu test python version issue #551

yiheng-wang-nv opened this issue Jan 25, 2024 · 0 comments · Fixed by #552

Comments

@yiheng-wang-nv
Copy link
Collaborator

already mentioned in Project-MONAI/MONAI#7416
model zoo tests also need to fix this issue

yiheng-wang-nv added a commit that referenced this issue Jan 29, 2024
Fixes #551 

### Description
This PR does the following three changes:
1. fix the python version issue in permerge cpu test
2. update two bundles to support black 24.1
3. update weekly cpu test to enable new bundles tests

### Status
**Ready**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv added a commit to yiheng-wang-nv/model-zoo that referenced this issue Jul 29, 2024
Fixes Project-MONAI#551 

### Description
This PR does the following three changes:
1. fix the python version issue in permerge cpu test
2. update two bundles to support black 24.1
3. update weekly cpu test to enable new bundles tests

### Status
**Ready**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant