Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Undefined companionWindowIds property of window on updateWindow #3930

Open
barmintor opened this issue Aug 27, 2024 · 0 comments
Open

Undefined companionWindowIds property of window on updateWindow #3930

barmintor opened this issue Aug 27, 2024 · 0 comments

Comments

@barmintor
Copy link
Collaborator

See #3437

I'm working on a plugin that updates the window from an interaction in the sidebar. When the update is processed, a selector (which is somewhat obscured by the intermediating software) triggers a similar error - namely, that companionWindowIds is undefined on the window (which does exist), and thus the call to companionWindowIds.map(...) fails.

This is happening on a fork of M3, but as far as I can tell the relevant code is unchanged in M4. I'm suspicious that there's a race condition here. It might also be something in my plugin, but I don't want to lose this thread.

barmintor added a commit to cul/mirador that referenced this issue Aug 27, 2024
barmintor added a commit to cul/mirador that referenced this issue Jan 27, 2025
barmintor added a commit to cul/mirador that referenced this issue Jan 28, 2025
barmintor added a commit to cul/mirador that referenced this issue Jan 30, 2025
barmintor added a commit to cul/mirador that referenced this issue Feb 1, 2025
barmintor added a commit to cul/mirador that referenced this issue Feb 2, 2025
barmintor added a commit to cul/mirador that referenced this issue Feb 3, 2025
barmintor added a commit to cul/mirador that referenced this issue Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant