Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Login/# text should be consistent #609

Closed
misaugstad opened this issue May 25, 2017 · 5 comments
Closed

Login/# text should be consistent #609

misaugstad opened this issue May 25, 2017 · 5 comments

Comments

@misaugstad
Copy link
Member

At the top of the landing page, the button is called "Login", but pops up a window with the title "#". I'm sure that (essentially) everyone understands that these are synonymous, but they should still be consistent.

Is there a reason/preference for choosing one over the other?

@sbower213
Copy link
Collaborator

Since the URL is #SignIn and the modal text says "Have an account? #!", I'm leaning towards making it #. Should the button be "#" for consistency with the adjacent button's capitals or "#" for consistency with the modal? Should any of these other texts be changed to match these changes?

@manaswisaha
Copy link
Member

I would go with # and modify other places to be consistent.

@jonfroehlich
Copy link
Member

jonfroehlich commented Jun 13, 2017 via email

@manaswisaha
Copy link
Member

manaswisaha commented Jun 13, 2017

To add some context to what @sbower213 was saying:

Should the button be "#" for consistency with the adjacent button's capitals or "#" for consistency with the modal?

image

# Modal
image

@jonfroehlich
Copy link
Member

To investigate this a bit, I just looked at some websites like Pinterest and Etsy.com that likely have non-technical users. It seems like "#" (lower case 'in' is most common).

Here are the results of my brief investigation (case sensitive).

  • Redfin: #
  • Etsy: #
  • Zillow: #
  • Ebay: #
  • Pinterest: Log in

Screenshots below. Note that this is the kind of design/UI research that I would expect all team members to perform when working on design/UI problems.

image

image

image

image

image

sbower213 added a commit that referenced this issue Jun 13, 2017
Resolves #609, text is updated to be more consistent across the site
@ghost ghost added the in progress label Jun 13, 2017
@ghost ghost removed in progress labels Jun 21, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants