Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Undocumented breaking change affecting autopep8 #1191

Closed
paugier opened this issue Aug 13, 2023 · 4 comments
Closed

Undocumented breaking change affecting autopep8 #1191

paugier opened this issue Aug 13, 2023 · 4 comments

Comments

@paugier
Copy link

paugier commented Aug 13, 2023

I guess pycodestyle.missing_whitespace_around_operator was removed in pycodestyle 2.11.0 (2023-07-29).

It breaks autopep8 (hhatto/autopep8#689). Currently, the most recent versions of pycodestyle and autopep8 are incompatible.

How this should be fixed? Which project (pycodestyle or autopep8) has to be adapted and how?

@paugier
Copy link
Author

paugier commented Aug 13, 2023

The commit which suppressed missing_whitespace_around_operator: f04e2a1

@sigmavirus24
Copy link
Member

Autopep8 needs to adjust

@paugier
Copy link
Author

paugier commented Aug 13, 2023

Should it be enough to just call missing_whitespace instead of missing_whitespace_around_operator in autopep8?

Shouldn't such breaking change be mentioned in https://pycodestyle.pycqa.org/en/latest/developer.html#changes?

@asottile
Copy link
Member

there is no public API of pycodestyle beyond the StyleGuide. calling the internal functions is at your own risk

cezarmoise added a commit to cezarmoise/scylla-cluster-tests that referenced this issue Nov 28, 2024
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to cezarmoise/scylla-cluster-tests that referenced this issue Nov 28, 2024
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
dimakr pushed a commit to cezarmoise/scylla-cluster-tests that referenced this issue Dec 11, 2024
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
dimakr pushed a commit to cezarmoise/scylla-cluster-tests that referenced this issue Dec 11, 2024
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Dec 11, 2024
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 8, 2025
Pins pycodestyle(https://pypi.org/project/pycodestyle/) to 2.10.0
More recent versions break autopep8 due to PyCQA/pycodestyle#1191
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants