Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Try to fix an AttributeError related to pycodestyle 2.11.0 #699

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

paugier
Copy link
Contributor

@paugier paugier commented Aug 13, 2023

This could fix #689 (see also #1191).

Note that I have no idea of the consequence of this simple change... However, it would be interesting to check if the tests could succeed with pycodestyle 2.11.0.

@paugier paugier force-pushed the fix-pycodestyle-missing_whitespace branch from efbe9d4 to f961833 Compare August 13, 2023 21:19
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b9110b) 97.83% compared to head (f961833) 97.83%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           1        1           
  Lines        2398     2402    +4     
=======================================
+ Hits         2346     2350    +4     
  Misses         52       52           
Files Changed Coverage Δ
autopep8.py 97.83% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaperilio
Copy link

shaperilio commented Aug 15, 2023

@paugier thanks for this; currently flake8 6.1.0 claims it needs pycodestyle 2.11 so we're in a bind here. They combined white space checks into one and autopep8 has them separated.

A potential issue I see here is that you made a change in fix_e225 and fix_e231 is just below it. These are the two things that got merged on the pycodestyle side. So I would:

  1. Put a comment somewhere in there explaining why you had to make this change, and that these two checks got merged, and
  2. Check if fix_e225 also fixes E231, in which case we should probably clean this up a bit more.

(Trying to avoid a situation down the road where someone wonders e.g. why fix_e231 never gets called, etc.)

@shaperilio
Copy link

#699, #696, #691, #690 are all the same. I suggest someone look into this comment and push their PR forward with a solution.

@hhatto
Copy link
Owner

hhatto commented Aug 25, 2023

thanks for contribution.
This has been fixed in pull-request #696, so we will close this one 🙏
We will release a new version within a few days.

@hhatto hhatto closed this Aug 25, 2023
@hhatto hhatto reopened this Aug 26, 2023
@hhatto hhatto merged commit daa0cce into hhatto:main Aug 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module 'pycodestyle' has no attribute 'missing_whitespace_around_operator'
4 participants