Skip to content

Commit

Permalink
build system: provide netif_ethernet implicitly
Browse files Browse the repository at this point in the history
If there is an Ethernet peripheral (periph_eth feature provided), we
can conclude that an Ethernet network interface can be provided.
  • Loading branch information
maribu committed May 27, 2024
1 parent ded7217 commit 48094c9
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 6 deletions.
4 changes: 4 additions & 0 deletions Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ FEATURES_CONFLICT += periph_usbdev:tinyusb_host
FEATURES_CONFLICT_MSG += "Package tinyUSB is not yet compatible with periph_usbdev."

# Features provided implicitly
ifneq (,$(filter periph_eth,$(FEATURES_PROVIDED)))

Check failure on line 36 in Makefile.features

View workflow job for this annotation

GitHub Actions / static-tests

Modules should not check the content of FEATURES_PROVIDED/REQUIRED/OPTIONAL
FEATURES_PROVIDED += netif_ethernet
endif

ifneq (,$(filter netif_%,$(FEATURES_PROVIDED)))

Check failure on line 40 in Makefile.features

View workflow job for this annotation

GitHub Actions / static-tests

Modules should not check the content of FEATURES_PROVIDED/REQUIRED/OPTIONAL
FEATURES_PROVIDED += netif
endif
1 change: 0 additions & 1 deletion boards/nucleo-f207zg/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ FEATURES_PROVIDED += periph_uart
FEATURES_PROVIDED += periph_usbdev

# Put other features for this board (in alphabetical order)
FEATURES_PROVIDED += netif_ethernet
FEATURES_PROVIDED += riotboot
FEATURES_PROVIDED += tinyusb_device

Expand Down
1 change: 0 additions & 1 deletion boards/nucleo-f429zi/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ FEATURES_PROVIDED += periph_uart
FEATURES_PROVIDED += periph_usbdev

# Put other features for this board (in alphabetical order)
FEATURES_PROVIDED += netif_ethernet
FEATURES_PROVIDED += tinyusb_device

# load the common Makefile.features for Nucleo boards
Expand Down
1 change: 0 additions & 1 deletion boards/nucleo-f439zi/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ FEATURES_PROVIDED += periph_uart
FEATURES_PROVIDED += periph_usbdev

# Put other features for this board (in alphabetical order)
FEATURES_PROVIDED += netif_ethernet
FEATURES_PROVIDED += tinyusb_device

# load the common Makefile.features for Nucleo boards
Expand Down
1 change: 0 additions & 1 deletion boards/nucleo-f767zi/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ FEATURES_PROVIDED += periph_uart
FEATURES_PROVIDED += periph_usbdev

# Put other features for this board (in alphabetical order)
FEATURES_PROVIDED += netif_ethernet
FEATURES_PROVIDED += riotboot
FEATURES_PROVIDED += tinyusb_device

Expand Down
1 change: 0 additions & 1 deletion boards/same54-xpro/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@ FEATURES_PROVIDED += periph_freqm
FEATURES_PROVIDED += periph_can

# Put other features for this board (in alphabetical order)
FEATURES_PROVIDED += netif_ethernet
FEATURES_PROVIDED += riotboot
FEATURES_PROVIDED += tinyusb_device
1 change: 0 additions & 1 deletion boards/stm32f746g-disco/features-shared.mk
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ FEATURES_PROVIDED += periph_usbdev_hs
FEATURES_PROVIDED += periph_usbdev_hs_ulpi

# Put other features for this board (in alphabetical order)
FEATURES_PROVIDED += netif_ethernet
FEATURES_PROVIDED += tinyusb_device

0 comments on commit 48094c9

Please # to comment.