sys/newlib/syscalls: _read_r fix potential buffer overflow #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a potential buffer overflow if more bytes are available than the count parameter.
jnohlgard
added
the
Type: bug
Merged
jnohlgard
added
the
CI: ready for build
|
I had #3111 lying around for a while. Seems shorter, what do you think? |
|
@kaspar030 your implementation is cleaner. Closing in favour of #3111 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(separated from #3101 because this is more than a simple warning fix)
Fixes a potential buffer overflow if more bytes are available than the count parameter.