Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

sys: newlib: use double-lock scheme for uart ringbuffer #3111

Merged
merged 1 commit into from
Jun 1, 2015
Merged

sys: newlib: use double-lock scheme for uart ringbuffer #3111

merged 1 commit into from
Jun 1, 2015

Conversation

kaspar030
Copy link
Contributor

No need for a loop in _read_r(). Also fixes count > rb.avail bug.

(vgl #3110).

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels May 29, 2015
@kaspar030 kaspar030 mentioned this pull request May 29, 2015
Closed
@kaspar030 kaspar030 force-pushed the fix_newlib__read_r branch from 2f54d21 to 052470c Compare May 29, 2015 10:28
@kaspar030
Copy link
Contributor Author

(last minute fix amended)

@PeterKietzmann PeterKietzmann mentioned this pull request May 29, 2015
Merged
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 29, 2015
@jnohlgard
Copy link
Member

ACK, waiting for Travis.

@jnohlgard jnohlgard self-assigned this May 30, 2015
@jnohlgard
Copy link
Member

Something is going on with Travis. Travis skipped everything..

@jnohlgard
Copy link
Member

@kaspar030 rebase after #3122 is merged

@haukepetersen
Copy link
Contributor

works on the samr21 and looks sane to me. ACK here, too.

@jnohlgard jnohlgard mentioned this pull request May 31, 2015
Closed
@jnohlgard jnohlgard added this to the Release 2015.06 milestone May 31, 2015
@miri64 miri64 mentioned this pull request May 31, 2015
Merged
@jnohlgard
Copy link
Member

needs rebase.

I think I forgot to remove my _read_r fix from #3101 before it was merged so this needs a rebase.

@kaspar030 kaspar030 force-pushed the fix_newlib__read_r branch from 052470c to be50f8b Compare June 1, 2015 10:13
@kaspar030
Copy link
Contributor Author

  • rebased

@kaspar030
Copy link
Contributor Author

I checked on iot_lab-M3 after rebase, but could someone take a quick look if the rebase went alright, and then press merge?

@kaspar030 kaspar030 mentioned this pull request Jun 1, 2015
Merged
@jnohlgard
Copy link
Member

rebase looks fine, &go!

jnohlgard pushed a commit that referenced this pull request Jun 1, 2015
Merge pull request #3111 from kaspar030/fix_newlib__read_r
4b1e158 
sys: newlib: use double-lock scheme for uart ringbuffer
@jnohlgard jnohlgard merged commit 4b1e158 into RIOT-OS:master Jun 1, 2015
@kaspar030 kaspar030 deleted the fix_newlib__read_r branch February 7, 2017 22:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jnohlgard jnohlgard

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2015.09
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @jnohlgard @haukepetersen