sys: newlib: make _read_r thread safe #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
Type: bug
|
Good catch! |
kaspar030
force-pushed
the
make_newlib__read_r_thread_safe
branch
from
be4fc65 to
5549d04
Compare
|
-rebased |
kaspar030
added
CI: ready for build
|
ACK for the change |
|
Did you test this on the IoT-Lab? |
|
Yes, working fine. |
|
no wait, I was testing default, and that uses uart0 ;) sec... |
|
Checked iot-lab. |
| count = count < rx_buf.avail ? count : rx_buf.avail; | ||
|
|
||
| return ringbuffer_get(&rx_buf, (char*)buffer, count); | ||
| res = ringbuffer_get(&rx_buf, (char*)buffer, count); |
There was a problem hiding this comment.
sorry for a late comment: I noticed that ringbuffer_get returns an unsigned int, do we need to cast that here?
There was a problem hiding this comment.
hm, before we just returned ringbuffer_get directly. And the compiler doesn't complain. And no RIOT device in the near future will have a ring buffer with 2^31 bytes, so not casting should be fine. :)
There was a problem hiding this comment.
Yeah, just nitpicking. We can merge this as-is in my opinion
|
ACK |
jnohlgard
pushed a commit
that referenced
this pull request
Jun 1, 2015
sys: newlib: make _read_r thread safe
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, there was a potential race condition because both ISR and the thread could access the ringbuffer simultaneously. This PR wraps the ringbuffer access from the thread into disable/restreIRQ calls.
(depends on #3111)