Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

shell: sc_icmpv6_echo: only allow unicast ping for now #3995

Closed
wants to merge 1 commit into from

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 29, 2015

Currently the ping shell command is too simple to handle multicast ping, so the simplest solution for now is to not allow it at all.

@miri64 miri64 added Area: network Area: Networking NSTF labels Sep 29, 2015
@miri64 miri64 added this to the Release 2015.09 milestone Sep 29, 2015
@cgundogan
Copy link
Member

Could you also PR this against the RC branch? Otherwise, I do not understand why you tagged this as Release 2015.09

@miri64
Copy link
Member Author

miri64 commented Sep 30, 2015

Will do, just forgot about it yesterday.

@OlegHahm
Copy link
Member

Hm, to me that still seems to be a workaround for an underlying problem. What about changing the netapi IPC send call to non-blocking? Since all layers have their message queues, the default behavior shouldn't change (messages are delivered), but the system won't get stuck any more in cases like this. (I checked with ping 100 ff02::1 0 0 and msg_try_send() in the corresponding netapi call and the system isn't hanging any more.)

@OlegHahm
Copy link
Member

With #4005 the problem seems to be solved in a less intrusive way then switching to non-blocking netapi calls.

@miri64
Copy link
Member Author

miri64 commented Sep 30, 2015

@OlegHahm did you check the state of the packet buffer, too?

@OlegHahm
Copy link
Member

No, but since the application hung after some time without the release and now doesn't hang any more, I assume it to be okay, but I will check.

@miri64
Copy link
Member Author

miri64 commented Oct 1, 2015

So with #4009 and #4013 this is not necessary anymore right? Then close?

@OlegHahm
Copy link
Member

OlegHahm commented Oct 1, 2015

I think so, yes.

@miri64 miri64 closed this Oct 1, 2015
@miri64 miri64 deleted the ping/fix/no-mc branch October 1, 2015 15:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: network Area: Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants