-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
shell: fix multicast pings #4005
Conversation
You are aware, that this is not correct, since the packets you receive before are also duplicates |
Yes, but there's no way to distinguish without a lot of added memory/complexity. |
I'm wondering if we shouldn't make it even mandatory for a thread registering at gnrc to have a message queue. What do you think? |
Added the queue also for the border router example, added a comment to explain the necessity, reduced the queue size, and made the error message for superfluous pongs more accurate. |
I remember that I tried to include an assert() for that sometime in the past, but someone (I really can't remember) was against it. |
Let's discuss #4010 after the release. |
I just figured out that only the combination of this PR and #4006 will fix the issue completely. |
Kind off was expecting something like that. How big is the packet loss with #4006? |
On native more or less 0. |
However the packetbuffer is not empty. |
The fragments in the packetbuffer look weird to me:
|
However, I'm not able to create a fragmented packet buffer on iotlabs. |
I think the changes in this PR are sane anyway. If you don't disagree, how about getting this merged quickly? |
Tests for Specs 02 to 06 succeed with #4006 and this PR. |
True the packet buffer looks really weird, since it looks like abandoned data... Otherwise, this change is a step in the right direction so ACK (is there a release version for it)? |
Yes, see #4009. |
Since it is likely that the main thread will send netapi IPC calls that expects a reply. These replies may come faster than the thread can handle them, causing the layers below to stuck.
ce93858
to
b538c74
Compare
squashed |
This PR introduces two things in order to fix pinging of multicast addresses (or more general: to be able to handle additional ICMPv6 echo replies):