testutils: mark tests in RC tracking issue and comment on status #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
force-pushed
the
pytest/enh/github
branch
from
56a805b to
c8d48ae
Compare
|
Rebased to current master |
This was referenced Aug 1, 2020
fjmolinas
reviewed
Aug 4, 2020
conftest.py
Outdated
Comment on lines
98
to
100
| result = yield | ||
| testutils.github.update_issue(report) | ||
| return result |
There was a problem hiding this comment.
I don't understand why return yield?
There was a problem hiding this comment.
yield in a keyword to yield to the caller. This can produce results in fact. So what is here is
return resultnot return yield.
This is done in case the wrapping pytest_runtest_logreport() returns something. See also https://docs.pytest.org/en/stable/writing_plugins.html#hookwrapper-executing-around-other-hooks
There was a problem hiding this comment.
Then again: It is not expected to return anything... so no idea... will remove.
There was a problem hiding this comment.
Thanks for the pointers to the documentation, it is clearer to me know.
|
please rebase and squash @miri64 |
miri64
force-pushed
the
pytest/enh/github
branch
from
08e331b to
98774d3
Compare
|
Rebased and squashed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the functionality seen in #172, so marking a task as done in the tracking issue if it is succeeding (and not already marked as done) and commenting the results (if they are not already provided)