-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
gh-actions: add workflow for release tests #174
Conversation
Looking at RIOT-OS/RIOT#14587 it might make sense to move this to |
With having it here, some webhook would be required to start the job on tag creation over at on:
push:
tags:
- '[0-9][0-9][0-9][0-9].[0-9][0-9]-RC[0-9]*'
- '[0-9][0-9][0-9][0-9].[0-9][0-9]' |
I think although it might be easier it mixes some some concerns, from what I see here it is something github wants to work on. For now it would seem to me that it would be somehow cleaner to have just a |
So you rather want to create two actions, one in |
I cant imagine the webhook requiring much editing. On the other side of the argument we would be adding more code into RIOT-OS/RIOT and that yaml file goes through a more costly review procedure (even if skipping ci-builds you have to wait for it to go through the queue) than if the bulk of the configuration is kept in this repo. That being said, I don't have a strong opinion on this so I would no insist on any approach. |
Just to be clear: I am just talking about moving the Release-Specs/.github/workflows/release-test.yml Lines 31 to 41 in d7d7f66
and none of the hooks are currently repo-dependent Release-Specs/.github/workflows/release-test.yml Lines 3 to 15 in d7d7f66
the move over there wouldn't even be that hard. |
In the end: the system under tests with this workflow is RIOT, not the release specs ;-). |
|
Can you rebase this one to have a better view of the PR? |
d7d7f66
to
af33c06
Compare
Rebased to current master and out-standing dependencies (#173 and #178). However, now that I ported it to RIOT-OS/RIOT#14646, I think I prefer it that way. |
77d477c will go into its own PR once confirmed it solves the problems with |
c6fa07a
to
97aa394
Compare
5d4bc83
to
f557a40
Compare
7bbd0af
to
eb8586e
Compare
fb96d78
to
b45fc87
Compare
b45fc87
to
9449a9b
Compare
Rebased and included #181 |
So this PR becomes obsolete once RIOT-OS/RIOT#14646 is in ? |
Yes. I mainly use this PR to track and test the remaining PRs required for RIOT-OS/RIOT#14646. |
But since #181 is the only relevant left, I think we can close this now. |
This provides a Github Actions Workflow to run the release tests both weekly currently configured for Sat 3:00 and on triggered events. For the triggered runs one can either use the REST API hook or, once this PR is merged into master, via the "Run workflow" mask in the Actions tab.
As input parameters the
riot_version
and thedocker_version
(for theriotbuild
image) can be chosen.riot_version
can be any git reference in theRIOT-OS/RIOT
repo, including commit SHA1s, branches or tags. Ifriot_version
is a release candidate tag (so name format like2020.07-RC2
), the framework will recognize this and will also manipulate the test tracking issue for that RC (see #173). The idea is, that once this PR gets merged a webhook the workflow is run once that tag is created inRIOT-OS/RIOT
.For the weekly cron job, the release tests are always run against the current master of
RIOT-OS/RIOT
.The current deployment can be checked here.
Dependencies
This PR includes
#164 (and all its dependencies),#173, and#178.