03-single-hop-ipv6-icmp/task04: stop pingers after force-ping #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2020
fjmolinas
approved these changes
Aug 4, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why some
nativetests are failing with high losses and many tests of spec 10 were failing outright. So I usedscapy's sniffer in the spec 10 tests and upload the PCAP generated by that to get a better picture what is going wrong. It turns out, there are a lot of ICMPv6 echo requests on the TAP interface. This can be seen in the PCAPs artifacts of this run. Turns out: Some of the force-pings in task 3.4 where not finished properly (even though they do locally).By sending a
SIGINT(= Ctrl+C) to the pingingbashREPLWrappers this can be fixed, as can be seen in this run. Don't worry that the run is failing its because of some linting error in my modifications to the spec 10 tests, there is currently a clean version running which should succed.As a bonus, task 3.6 is now succeeding reliably (also for the same reason mentioned in the introducing sentence)