-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding new SC and Pool for RBD #1756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b884a0
to
8760c02
Compare
nirs
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the big picture but changes look very nice!
8760c02
to
9a91484
Compare
This commit adds a new storage class and pool for RBD, which allows the ramen code base to exercise the filtering logic when there are multiple storage classes in the environment. This also prepares the environment for scenarios where more than two workloads use different storage classes. Signed-off-by: rakeshgm <rakeshgm@redhat.com>
9a91484
to
56f26f0
Compare
I have updated the PR description and the commit message |
nirs
approved these changes
Feb 6, 2025
ELENAGER
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 11, 2025
This commit continues the improvements introduced in [1] and [2] by adding new VRCs and VSCs based on the newly created SCs. Additionally, it includes minor fixes to prevent duplicate SC-ID generation. References: [1] RamenDR#1756 [2] RamenDR#1756 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 12, 2025
This commit continues the improvements introduced in [1] and [2] by adding new VRCs and VSCs based on the newly created SCs. Additionally, it includes minor fixes to prevent duplicate SC-ID generation. References: [1] RamenDR#1756 [2] RamenDR#1756 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 17, 2025
This commit continues the improvements introduced in [1] and [2] by adding new VRCs and VSCs based on the newly created SCs. Additionally, it includes minor fixes to prevent duplicate SC-ID generation. References: [1] RamenDR#1756 [2] RamenDR#1756 Signed-off-by: rakeshgm <rakeshgm@redhat.com> (cherry picked from commit 538dc1d)
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 18, 2025
This commit continues the improvements introduced in [1] and [2] by adding new VRCs and VSCs based on the newly created SCs. Additionally, it includes minor fixes to prevent duplicate SC-ID generation. References: [1] RamenDR#1756 [2] RamenDR#1756 Signed-off-by: rakeshgm <rakeshgm@redhat.com> (cherry picked from commit 538dc1d)
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 18, 2025
This commit continues the improvements introduced in [1] and [2] by adding new VRCs and VSCs based on the newly created SCs. Additionally, it includes minor fixes to prevent duplicate SC-ID generation. References: [1] RamenDR#1756 [2] RamenDR#1756 Signed-off-by: rakeshgm <rakeshgm@redhat.com> (cherry picked from commit 538dc1d)
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 18, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 18, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
asn1809
pushed a commit
to asn1809/ramen
that referenced
this pull request
Feb 28, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new storage class and pool for RBD, which allows the ramen code base to exercise the filtering logic when there are multiple storage classes in the environment. This also prepares the environment for scenarios where more than two workloads use different storage classes.