Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding new SC and Pool for RBD #1756

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

rakeshgm
Copy link
Member

@rakeshgm rakeshgm commented Jan 20, 2025

This commit adds a new storage class and pool for RBD, which allows the ramen code base to exercise the filtering logic when there are multiple storage classes in the environment. This also prepares the environment for scenarios where more than two workloads use different storage classes.

@rakeshgm rakeshgm requested review from nirs and ShyamsundarR January 20, 2025 12:39
@rakeshgm rakeshgm force-pushed the drenv-multisc branch 8 times, most recently from 8b884a0 to 8760c02 Compare January 23, 2025 10:18
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the big picture but changes look very nice!

This commit adds a new storage class and pool for RBD, which allows the
ramen code base to exercise the filtering logic when there are multiple
storage classes in the environment. This also prepares the environment
for scenarios where more than two workloads use different storage
classes.

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
@rakeshgm
Copy link
Member Author

Missing the big picture but changes look very nice!

I have updated the PR description and the commit message

@rakeshgm rakeshgm marked this pull request as ready for review January 24, 2025 11:02
@nirs nirs self-requested a review February 4, 2025 03:49
@rakeshgm rakeshgm requested a review from ELENAGER February 10, 2025 11:23
Copy link
Member

@ELENAGER ELENAGER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakeshgm rakeshgm merged commit b597b04 into RamenDR:main Feb 11, 2025
23 checks passed
@rakeshgm rakeshgm deleted the drenv-multisc branch February 11, 2025 00:22
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 11, 2025
This commit continues the improvements introduced in [1] and [2] by
adding new VRCs and VSCs based on the newly created SCs. Additionally, it
includes minor fixes to prevent duplicate SC-ID generation.

References:
[1] RamenDR#1756
[2] RamenDR#1756

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 12, 2025
This commit continues the improvements introduced in [1] and [2] by
adding new VRCs and VSCs based on the newly created SCs. Additionally, it
includes minor fixes to prevent duplicate SC-ID generation.

References:
[1] RamenDR#1756
[2] RamenDR#1756

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 17, 2025
This commit continues the improvements introduced in [1] and [2] by
adding new VRCs and VSCs based on the newly created SCs. Additionally, it
includes minor fixes to prevent duplicate SC-ID generation.

References:
[1] RamenDR#1756
[2] RamenDR#1756

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit 538dc1d)
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 18, 2025
This commit continues the improvements introduced in [1] and [2] by
adding new VRCs and VSCs based on the newly created SCs. Additionally, it
includes minor fixes to prevent duplicate SC-ID generation.

References:
[1] RamenDR#1756
[2] RamenDR#1756

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit 538dc1d)
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 18, 2025
This commit continues the improvements introduced in [1] and [2] by
adding new VRCs and VSCs based on the newly created SCs. Additionally, it
includes minor fixes to prevent duplicate SC-ID generation.

References:
[1] RamenDR#1756
[2] RamenDR#1756

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit 538dc1d)
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 18, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicatestorageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 18, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicatestorageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicatestorageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicatestorageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicate storageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicate storageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
nirs pushed a commit that referenced this pull request Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicate storageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] #1756
[2] #1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm added a commit to rakeshgm/ramen that referenced this pull request Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicate storageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
asn1809 pushed a commit to asn1809/ramen that referenced this pull request Feb 28, 2025
In the referenced PRs [1] and [2], two StorageClasses were
created for RBD and two for CephFS. Both RBD and CephFS
StorageClasses had duplicate storageIDs. This commit resolves
the duplicate storageID issue.

References:
[1] RamenDR#1756
[2] RamenDR#1770

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants