Add new SC Names and Pools for Ceph-FS #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change in the coming in, we will need changes in ocm-ramen-samples for ceph-fs sc name |
ELENAGER
reviewed
Jan 28, 2025
| @@ -12,4 +12,4 @@ spec: | |||
| resources: | |||
| requests: | |||
| storage: 1Gi | |||
| storageClassName: rook-cephfs | |||
| storageClassName: rook-cephfs-test-fs1 | |||
There was a problem hiding this comment.
Maybe also pass filesystem name as parameter, like rook-cephfs-$fsname?
There was a problem hiding this comment.
i had thought about it earlier. I was thinking it would spin more changes. but then again it's just one file. I will make the change.
nirs
reviewed
Jan 29, 2025
test/addons/rook-cephfs/test
Outdated
| "--kustomize", | ||
| "provision-test", | ||
| context=cluster, | ||
| f"--namespace={NAMESPACE}", "--filename=-", input=yaml, context=cluster | ||
| ) |
There was a problem hiding this comment.
Why not keep the code as is, and modify the pvc to use "test-fs1"?
There was a problem hiding this comment.
hmm, the changes are not much. its a separate commit. i will drop it.
rakeshgm
force-pushed
the
drenv-multisc-fs
branch
from
5e47da2 to
731b972
Compare
nirs
reviewed
Feb 6, 2025
The commit adds a new storage classes and pools for Cephfs, which allows the ramen code base to exercise the filtering logic when there are multiple storage classes in the environment. This also prepares the environment for scenarios where more than two workloads use different storage classes. The older Ceph-FS names have been renamed and accordingly the changes have been made to the other test files Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
force-pushed
the
drenv-multisc-fs
branch
from
731b972 to
4ab422d
Compare
nirs
approved these changes
Feb 10, 2025
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 18, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 18, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicatestorageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
added a commit
to rakeshgm/ramen
that referenced
this pull request
Feb 19, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
asn1809
pushed a commit
to asn1809/ramen
that referenced
this pull request
Feb 28, 2025
In the referenced PRs [1] and [2], two StorageClasses were created for RBD and two for CephFS. Both RBD and CephFS StorageClasses had duplicate storageIDs. This commit resolves the duplicate storageID issue. References: [1] RamenDR#1756 [2] RamenDR#1770 Signed-off-by: rakeshgm <rakeshgm@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commit adds a new storage classes and pools for Cephfs, which
allows the ramen code base to exercise the filtering logic when there
are multiple storage classes in the environment. This also prepares the
environment for scenarios where more than two workloads use different
storage classes.
The older Ceph-FS names have been renamed and accordingly the
changes have been made to the other test files like drenv-self-tests
and e2e