Skip to content

Book 1 - the order of diffuse spheres #1013

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
genmeblog opened this issue Apr 28, 2022 · 3 comments
Closed

Book 1 - the order of diffuse spheres #1013

genmeblog opened this issue Apr 28, 2022 · 3 comments
Assignees

Comments

@genmeblog
Copy link

genmeblog commented Apr 28, 2022

book1-review branch. The order of images is incorect imho.

Image 7 - looks like after gamma correction, which is introduced later in the book
Image 8 and 9 - the shadows are much darker than in the next image, my render of image 9 produces below result (ligher shadows):
ch08b

I use different method of genereting random vector from the ball (normalized gaussians rather than rejection), so maybe this is the reason. However there is a followin statement below image 10: "The shadows are more pronounced after the change". This statement suggests that images 8 and 9 should have ligher shadows, not darker.

@hollasch
Copy link
Collaborator

Ref #778

@hollasch hollasch added this to the v4.0.0-rel milestone Apr 28, 2022
@tysonliddell
Copy link

tysonliddell commented Mar 13, 2023

I bumped into this same issue and banged my head against the wall trying to get the same result as the book.

Image 7 appears to show the result after some kind of enhancement has been applied, but the result the code gives you at this stage is much darker. This can be confirmed by checking out this repo at 516fb5c (master branch at the time of writing) and applying this patch to remove code added in later sections. This yields the images below.

No gamma correction or shadow acne fix applied (this is what Image 7 should look like)

no-gamma

Gamma correction applied

with_gamma

Removing shadow acne

with_gamma_and_sa

@tysonliddell
Copy link

tysonliddell commented Mar 13, 2023

Looks like the cause of Image 7 in the book being much lighter than what is obtained when following the code might be due to #875 (comment). However, the images above are what you obtain with the book in its current form.

@hollasch hollasch modified the milestones: v4.0.0-rel, v4.0.0 Mar 15, 2023
@hollasch hollasch self-assigned this Mar 15, 2023
@hollasch hollasch modified the milestones: v4.0.0, v4.0.0-rel May 11, 2023
@hollasch hollasch modified the milestones: v4.0.0-rel, v4.0.0-book1-rel Jun 19, 2023
hollasch added a commit that referenced this issue Jul 26, 2023
This also adds a new image illustrating the results of removing shadow
acne.

All images have been renumbered accordingly.

Resolves #875
Resolves #914
Resolves #978
Resolves #1013
Resolves #1182
hollasch added a commit that referenced this issue Jul 26, 2023
This also adds a new image illustrating the results of removing shadow
acne.

All images have been renumbered accordingly.

Resolves #875
Resolves #914
Resolves #978
Resolves #1013
Resolves #1182
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants