-
Notifications
You must be signed in to change notification settings - Fork 910
Book 1 - the order of diffuse spheres #1013
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Ref #778 |
I bumped into this same issue and banged my head against the wall trying to get the same result as the book. Image 7 appears to show the result after some kind of enhancement has been applied, but the result the code gives you at this stage is much darker. This can be confirmed by checking out this repo at 516fb5c (master branch at the time of writing) and applying this patch to remove code added in later sections. This yields the images below. No gamma correction or shadow acne fix applied (this is what Image 7 should look like)Gamma correction appliedRemoving shadow acne |
Looks like the cause of Image 7 in the book being much lighter than what is obtained when following the code might be due to #875 (comment). However, the images above are what you obtain with the book in its current form. |
book1-review branch. The order of images is incorect imho.
Image 7 - looks like after gamma correction, which is introduced later in the book

Image 8 and 9 - the shadows are much darker than in the next image, my render of image 9 produces below result (ligher shadows):
I use different method of genereting random vector from the ball (normalized gaussians rather than rejection), so maybe this is the reason. However there is a followin statement below image 10: "The shadows are more pronounced after the change". This statement suggests that images 8 and 9 should have ligher shadows, not darker.
The text was updated successfully, but these errors were encountered: