Skip to content

Book 1, Image 16 for a hollow sphere does not reflect the result of the code #914

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Tracked by #778
bassicali opened this issue Aug 24, 2021 · 0 comments
Closed
Tracked by #778
Assignees

Comments

@bassicali
Copy link

bassicali commented Aug 24, 2021

This is image 16:

image

But if I follow along with the code being implemented in the book, I get this (disregard the right sphere):
image

The code I found in the old repository gives results that are closer to what's shown in image 16.
image

But even that gives a starkly different result if I move the camera somewhere else:
image

Compare to image 19:
image

Can anyone point me to the code that actually produces the book's results?

@bassicali bassicali changed the title Book 1, Image 16 does not reflect the result of the code Book 1, Image 16 for a hollow sphere does not reflect the result of the code Aug 24, 2021
@hollasch hollasch added this to the v4.0.0-rel milestone Oct 20, 2021
@hollasch hollasch self-assigned this Oct 20, 2021
@hollasch hollasch modified the milestones: v4.0.0-rel, v4.0.0-book1-rel Jun 19, 2023
hollasch added a commit that referenced this issue Jul 26, 2023
This also adds a new image illustrating the results of removing shadow
acne.

All images have been renumbered accordingly.

Resolves #875
Resolves #914
Resolves #978
Resolves #1013
Resolves #1182
hollasch added a commit that referenced this issue Jul 26, 2023
This also adds a new image illustrating the results of removing shadow
acne.

All images have been renumbered accordingly.

Resolves #875
Resolves #914
Resolves #978
Resolves #1013
Resolves #1182
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants