Skip to content

v1.0 cherry picks #450

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 29 commits into from
Sep 2, 2020
Merged

v1.0 cherry picks #450

merged 29 commits into from
Sep 2, 2020

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Aug 24, 2020

Currently cherry picked, but still not ready to be merged due to failed tests (revising and fixing it):

ba008bb Build: setuptools-related fix (#455)
c3b3e7c Fixed artifacts handling + added tests logs aggregation (#445)
b1494aa Fixed flagged as "getkeys-api" during the registration ( AI.DAGRUN, AI.DAGRUN_RO, AI.MODELRUN, AI.SCRIPTRUN ) (#438)
86ec431 Dependencies in ramp.yml (#444)
573d7dd Fixed platforms build problem (#441)
26faf7e CircleCI: Fixed problem with GPU testing (#440)
3019629 Updated support email and Orobix to Tensorwork on ramp file (#436)
544e36e [add] Add relevant RedisAI config entries to the INFO output, so that standard monitoring systems would be able to monitor them. (#396)
6a14c04 Update mkdocs.yml (#432)
f124a0e submodule pull moved up (#428)
66477b4 Docker6.0.5 (#427)
77e94a0 Added hooks/post_checkout to handle dockerhub build failures (#425)
9cb7791 CircleCI: fixed redis installation in coverage builds (#423)
aa332b5 Add missing files
cb70069 Add test for inconsistent zero batch output
2904fdf Update README.md
ccf0d5c Fix run info memleaks (#412)
7f87f85 YOLOv3 crash with empty image hotfix
f7fbb29 Enable chunking for large models in AOF, RDB, replication and MODELGET (#387)
a5d1524 Avoid splitting outputs in batches when nbatches == 1 (#406)
fcdf0d2 Llapi updates (#400)
6e65a42 CI: platform-build-defs -> on-master-and-version-tags (#405)
393604a CircleCI: increased GPU test timeout to 40m (#404)
ad6150f Multi-platform build (#398)
6df468f atomic ref count (#403)
1a3f394 Add support for variadic arguments to SCRIPT (#395)
3cd5caf [WIP] Enable AI.SCRIPTRUN on AI.DAGRUN* (#383)
a742faa [WIP] add C API reference to docs using auto tool (#368)
2d2a0af Fix for python3 issues in readies (#379)
16729d3 Introduced readies submodule (#377)

rafie and others added 10 commits August 24, 2020 12:23
* Introduced readies submodule

* Fix in paella

* Updated get_deps.sh and docs
* [add] add C API reference to docs using auto tool ( python3 generate_llapi_reference.py )

* [add] generating C API reference on the fly

* [add] moving api_reference under Developer Nav

Co-authored-by: Luca Antiga <luca.antiga@orobix.com>
* [add] decoupled scriptrun command parsing from runtime scriptrun.

* [add] split positive/negative tests on pytorch scriptrun.

* [add] refactor AI.DAGRUN_RO and AI.DAGRUN to use the same code base (with read/write modes)

* [add] added positive and negative tests for dagrun with scriptrun

* [add] updated documentation to reflect scriptrun support on dagrun

* [add] added example enqueuing multiple SCRIPTRUN and MODELRUN commands within a DAG
* Add support for variadic arguments to SCRIPT

* Add negative errors
* added low level api return redis types

* added variadic to llapi

* fixed memory issue for params array re-alloc
* Avoid splitting outputs in batches when nbatches == 1

* Add batch size checks

* Fix batch checks

* Update readies

* Add bad batching test
@filipecosta90
Copy link
Collaborator Author

filipecosta90 commented Aug 26, 2020

we'll also need to cherry pick #443 and #445

lantiga and others added 13 commits August 31, 2020 23:28
* Update Dockerfile

* Update Dockerfile.arm

* Update Dockerfile.gpu
… standard monitoring systems would be able to monitor them. (#396)
* [add] updated support email and Orobix to Tensorwork on ramp file

Co-authored-by: Sherin Thomas <sherin@tensorwerk.com>
* Fixed platforms build problem

* Build: updated Redis versions

* Build: another Redis version update
…I.DAGRUN_RO, AI.MODELRUN, AI.SCRIPTRUN ) (#438)

* [wip] wip on fixing the commands being flagged as getkeys-api during the registration. ( AI.MODELRUN, AI.SCRIPTRUN, AI.DAGRUN, AI.DAGRUN_RO )

* [add] pytorch oss cluster tests passing

* [add] TensorFlow lite tests passing on oss cluster

* [add] ONNX tests passing on oss cluster

* [add] TensorFlow tests passing on oss cluster

* [wip] wip on dag

* [add] DAG tests passing on oss cluster

* [add] enabling oss cluster tests on CI

* [add] bumping rmbuilder version from 6.0.1 to 6.0.5 on circleci

* [fix] fixed potential invalid mem accesses on RedisAI_DagRunSyntaxParser, RAI_parseDAGPersistArgs

* [fix] fixed RAI_FreeDagOp wrongfully calling RedisModule_Free on dagOp->inkeys, dagOp->outkeys

* [fix] fixed dictKey allocation on RAI_parseDAGLoadArgs

* [add] alter Sanitizer tests to accommodate keys on the same slot.

* [add] extracted the methods to respond to RedisModule_IsKeysPositionRequest() from main code of dagrun,modelrun, and scriptrun to specific methods

* [fix] Fixes per PR review

* [fix] fixes per PR review

* [fix] fix per CI ascii conversion error on test_dagro_modelrun_financialNet_no_writes_multiple_modelruns
* Make sure we reassign the pointer in array_append

* Fix case-sensitive comparison for devicestr

* Fix sanitizer tests

(cherry picked from commit 5c7813e)
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #450 into 1.0 will increase coverage by 0.46%.
The diff coverage is 82.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.0     #450      +/-   ##
==========================================
+ Coverage   72.60%   73.07%   +0.46%     
==========================================
  Files          21       21              
  Lines        4381     4554     +173     
==========================================
+ Hits         3181     3328     +147     
- Misses       1200     1226      +26     
Impacted Files Coverage Δ
src/config.c 18.75% <0.00%> (ø)
src/redisai.h 0.00% <0.00%> (ø)
src/model.c 70.79% <62.50%> (+1.11%) ⬆️
src/redisai.c 76.43% <70.73%> (-2.46%) ⬇️
src/script.c 65.46% <72.15%> (+1.75%) ⬆️
src/backends/tensorflow.c 65.45% <73.68%> (-0.17%) ⬇️
src/backends/onnxruntime.c 68.63% <79.31%> (+0.51%) ⬆️
src/dag.c 88.34% <88.74%> (+0.07%) ⬆️
src/backends/torch.c 82.82% <100.00%> (+0.32%) ⬆️
src/background_workers.c 83.50% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3e6b9...ba008bb. Read the comment docs.

* Snapshot packages are placed into http://redismodules.s3.amazonaws.com/redisai/snapshots. Private branches (i.e., non-master) are also supported, just need to enable deploy-snapshot in config.yml to fire on on-any-branch rather than just on-master.
* Release packages are placed into http://redismodules.s3.amazonaws.com/redisai, and it's going to be crowded in there, so we may want to consider putting each version into its own directory.
* `BB` in-source breakpoints are now supported (in `DEBUG=1` builds): put `BB;` inside the code and it will stop if you're running under gdb.
* Tests results in CircleCI are now aggregated as artifacts.
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisAI v1.0.1 LLAPI not being properly loaded by RedisGears v1.0.1
5 participants