Skip to content

Increase refcount for persisted tensors #454

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

lantiga
Copy link
Contributor

@lantiga lantiga commented Aug 31, 2020

This PR is a hotfix for a memory issue with persisted tensor on master.

The issue has been spotted during the analysis of #450.

@lantiga
Copy link
Contributor Author

lantiga commented Aug 31, 2020

@rafie FYI there's a CI issue on the gpu machine

@rafie
Copy link
Contributor

rafie commented Aug 31, 2020

@lantiga pip is giving us some hard times with the 20.x versions. I'll resolve it on master.

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #454 into master will decrease coverage by 0.10%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   75.00%   74.89%   -0.11%     
==========================================
  Files          21       21              
  Lines        4916     4904      -12     
==========================================
- Hits         3687     3673      -14     
- Misses       1229     1231       +2     
Impacted Files Coverage Δ
src/dag.c 88.23% <66.66%> (-0.34%) ⬇️
src/run_info.c 87.50% <100.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fcd0d...53fe088. Read the comment docs.

@gkorland gkorland requested a review from DvirDukhan September 9, 2020 12:07
@lantiga lantiga closed this Sep 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants