CircleCI: support for intergration branches #567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 72.31% 72.35% +0.03%
==========================================
Files 37 37
Lines 5917 5917
==========================================
+ Hits 4279 4281 +2
+ Misses 1638 1636 -2
Continue to review full report at Codecov.
|
.circleci/config.yml
Outdated
| filters: | ||
| branches: | ||
| only: master | ||
| tags: | ||
| only: /^v[0-9].*/ |
There was a problem hiding this comment.
remove on-master-and-version-tags as it is no longer in use, or combine both definitions
| @@ -405,7 +421,7 @@ workflows: | |||
| # <<: *on-version-tags | |||
| - deploy-snapshot: | |||
| <<: *after-platform-builds | |||
| <<: *on-master | |||
| <<: *on-integ-branch | |||
There was a problem hiding this comment.
why do we want integ branch snapshots? will it overwrite existing versions?
There was a problem hiding this comment.
like we get a master snapshot, we may want integration branch snapshots, with corresponding names, like redisai/snapshots/redisai-cpu-onnxruntime.linux-bionic-x64.1.2.tgz.
we can limit ourselves to on-master at the moment.
(cherry picked from commit 80bf0eb)
No description provided.