Skip to content

CircleCI: support for intergration branches #567

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jan 20, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,17 @@ on-master: &on-master
filters:
branches:
only: master
tags:
ignore: /.*/

on-integ-branch: &on-integ-branch
filters:
branches:
only:
- master
- /^\d+\.\d+.*$/
tags:
ignore: /.*/

on-version-tags: &on-version-tags
filters:
Expand All @@ -344,18 +355,20 @@ on-version-tags: &on-version-tags
tags:
only: /^v[0-9].*/

on-master-and-version-tags: &on-master-and-version-tags
on-integ-and-version-tags: &on-integ-and-version-tags
filters:
branches:
only:
- master
- /^\d+\.\d+.*$/
tags:
only: /^v[0-9].*/


platform-build-defs: &platform-build-defs
requires:
- build-debian
<<: *on-master-and-version-tags
<<: *on-integ-and-version-tags
# <<: *on-any-branch # debugging

after-platform-builds: &after-platform-builds
Expand Down Expand Up @@ -405,7 +418,7 @@ workflows:
# <<: *on-version-tags
- deploy-snapshot:
<<: *after-platform-builds
<<: *on-master
<<: *on-integ-branch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we want integ branch snapshots? will it overwrite existing versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like we get a master snapshot, we may want integration branch snapshots, with corresponding names, like redisai/snapshots/redisai-cpu-onnxruntime.linux-bionic-x64.1.2.tgz.
we can limit ourselves to on-master at the moment.

- deploy-release:
<<: *after-platform-builds
<<: *on-version-tags
Expand All @@ -414,7 +427,9 @@ workflows:
triggers:
- schedule:
cron: "20 17 * * *"
<<: *on-master
filters:
branches:
only: master
jobs:
- build-macos:
<<: *never # temporarily disabled