Increased net flares to 10

[tritonas00]

and bumped protocol version to 2.43

goes by hand with RigsOfRods/ror-server#109

closes #2664

not tested yet

[ohlidalp]

TODO:

• in "SimConstants.h", add MAX_CLIGHTS=10 with comment //!< See RoRnet::Netmask and enum events in InputEngine.h
• enlarge Actor::m_net_custom_lights to MAX_CLIGHTS and make it int;
• in ActorSpawner::InitializeRig(), put for (int i=0; i<MAX_CLIGHTS; ++i) { m_net_custom_lights = -1; }, remove existing code.
• in Actor::[get/set]CustomLightVisible(), fix up the range check and simplify the code to m_net_custom_lights[number] != -1 and reading/setting ar_flares[m_net_custom_lights[number]].controltoggle_status

What the :: means in C++: https://stackoverflow.com/a/3480366

[tritonas00]

Done (multiple facepalms incoming... 😆)

[ohlidalp]

Nice work

[tritonas00]

@only-a-ptr

https://github.com/RigsOfRods/rigs-of-rods/pull/2690/files#diff-2b5d30a8bd6eb8a53fefb2a3c3bf32ec559db32ba884c654805afdede400dc5bR4544

maybe it should be if (m_net_custom_lights[number] < ar_flares.size() && ...) ?

[ohlidalp]

New requirement based on #2664 (comment)

• delete int m_net_custom_lights_count, make it bool m_net_custom_light_active[MAX_CLIGHTS]
• in spawner, assign 'false' instead of -1 in the init loop. Delete all other code.
• in Actor::UpdateFlareStates(float dt), under the ar_flares[i].controltoggle_status = ! ar_flares[i].controltoggle_status; line, add this:

m_net_custom_light_state[ar_flares[i].controlnumber - 1] = ar_flares[i].controltoggle_status;

• change the [get/set]CustomLightVisible to just read/write m_net_custom_light_active[number]

That should do the trick. If the code is confusing, I'll explain.

new requirements

[tritonas00]

Done (i think 😄)

And probably wrong. We send 6 lights

but we get 1

[ohlidalp]

Replaced by #2729