Display all 10 user flares in multiplayer.

[ohlidalp]

Continued from #2690

Testing vehicle:
netflare-agoras.zip

goes by hand with RigsOfRods/ror-server#109

closes #2664

[tritonas00]

Now tatra custom lights don't open at all, and log spams:

AngelScript: invalid custom-light ID -1, allowed range is 0-9

--> #2551 (comment)

https://forum.rigsofrods.org/resources/tatra-t813-dakar.145/
ctrl 1 2 3 control the custom lights (master branch):

[ohlidalp]

@tritonas00 I can't reproduce it. Flares seem to work perfectly. I have a freshly downloaded tatra ZIP from your link.

[WillyB1337]

Have you pushed this update @only-a-ptr?
ohlidalp@9e5ef23
There's no commit of that yet.

[tritonas00]

Found the issue:

I had

It works with

It should work in single player, with the first option though, like master branch

Network works fine:

👍

[Zentro]

Works as expected here.

[tritonas00]

Eeeh

produces the

AngelScript: invalid custom-light ID -1, allowed range is 0-9

Master didn't had that issue, It was a bug in master?

[ohlidalp]

With what vehicle? Open the .truck and paste the flares here please. Meanwhile I'll test it.

[tritonas00]

With the tatra

flares2
;RefNode,X,Y,OffsetX, OffsetY, OffsetZ, Type, ControlNumber, BlinkDelay, size MaterialName
;front
 201, 202, 206, 0.300, 0.179, 1.250, u,  1, 0, 1.5 t813_flare_brights/SOLID/TEX/t813_brights.png
 201, 202, 206, 0.300, 0.200, 0.750, f, -1, 0, 2.9 t813_flare_poslight/SOLID/TEX/t813_poslight.png
 201, 202, 206, 0.665, 0.169, 1.450, u,  2, 0, 2.0 t813_flare_brights/SOLID/TEX/t813_brights.png

 204, 205, 209, 0.333, 0.169, 1.450, u,  2, 0, 2.0 t813_flare_brights/SOLID/TEX/t813_brights.png
 204, 205, 209, 0.700, 0.209, 0.750, f, -1, 0, 2.9 t813_flare_poslight/SOLID/TEX/t813_poslight.png
 204, 205, 209, 0.700, 0.179, 1.250, u,  1, 0, 1.5 t813_flare_brights/SOLID/TEX/t813_brights.png

 123, 124, 134, 0.057, 0.000, 2.750, u,  3, 0, 2.2 t813_flare_brights/SOLID/TEX/t813_brights.png
 125, 127, 135, 0.974, 0.000, 2.750, u,  3, 0, 2.2 t813_flare_brights/SOLID/TEX/t813_brights.png
;rear
 229, 228, 224, 0.759, 0.660, 0.020, b, -1, 0, 1.5 t813_brakelights.png/SOLID/TEX/t813_brakelights.png
 233, 232, 227, 0.241, 0.660, 0.020, b, -1, 0, 1.5 t813_brakelights.png/SOLID/TEX/t813_brakelights.png

 233, 232, 227, 0.714,-1.493, 0.000, u,  4, 0, 3   t813_brakelights.png/SOLID/TEX/t813_brakelights.png

 233, 232, 227, 0.586, 1.720, 1.520, R, -1, 0, 1.5 t813_flare_brights/SOLID/TEX/t813_brights.png

 129, 130, 125, 1.000, 0.000, 0.000, l, -1,-1,-1 tracks/trans
 128, 129, 123, 0.000, 0.000, 0.000, r, -1,-1,-1 tracks/trans

[ohlidalp]

You're right, reproduced.

To explain: with "Lights" set to "only cur. vehicle main lights", the spawner left the controlnumber on default value -1. My new simplified code uses that value to update flare states by calling getCustomLightVisible(). The confusing bit is that the "Lights" setting only affects light sources (environment illumination), not the visible flares.