Fixed incorrect reverse light sound updating over network

[tritonas00]

Reported from discord:

there’s this bug with the reverse beep being triggered every frame when the remote vehicle engine is not running

[ohlidalp]

this way, the sound will never play. Try this example program at http://cpp.sh/:

// Example program
#include <iostream>
#include <string>

int main()
{
    bool b0 = false;
    bool b1 = true;
    const int mask = 8; // NETMASK_REVERSE
    
    if (b0 & mask) std::cout << "b0 " << std::endl;
    if (b1 & mask) std::cout << "b1 " << std::endl;
    std::cout << "finished" << std::endl;

}

checking a bool variable against a bit mask is nonsense in general.

The right fix is to check if the sound already runs:

    if (m_net_reverse_light) {
     if (!SOUND_GET_STATE(ar_instance_id, SS_TRIG_REVERSE_GEAR)) { // not running yet?
        SOUND_START(ar_instance_id, SS_TRIG_REVERSE_GEAR); } }

[tritonas00]

tried it, i get the same sound when the engine is not running and reverse is on

does the reverse sound loop refresh rate takes account engine rpm or something?

or maybe we can send the sound only if engine is running

[tritonas00]

So in single player the reverse light sound plays only if engine is running.

Made it that way on MP also, so it fixes the issue now.

[ohlidalp]

Looks good.