Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed segfault with remote locked actors and reverse #2702

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

tritonas00
Copy link
Collaborator

@tritonas00 tritonas00 commented Mar 5, 2021

Player A: Spawn sisu and trailer, lock them and wait
Player B: Spawn sisu and trailer, lock them and put reverse
Player A segfaults:

Thread 1 "RoR" received signal SIGSEGV, Segmentation fault.
0x00005555558160f4 in RoR::Actor::CalcNetwork (this=this@entry=0x5555611245f0)
    at /home/babis/Downloads/ror-dependencies/rigs-of-rods/source/main/physics/Actor.cpp:621
621        if (m_net_reverse_light && ar_engine->IsRunning())
(gdb) bt
#0  0x00005555558160f4 in RoR::Actor::CalcNetwork (this=this@entry=0x5555611245f0)
    at /home/babis/Downloads/ror-dependencies/rigs-of-rods/source/main/physics/Actor.cpp:621
#1  0x0000555555832e16 in RoR::ActorManager::UpdateActors (this=0x555555be3e40 <RoR::App::g_game_context+64>, player_actor=0x55555df12190)
    at /home/babis/Downloads/ror-dependencies/rigs-of-rods/source/main/physics/ActorManager.cpp:1037
#2  0x0000555555617ce0 in RoR::GameContext::UpdateActors (this=<optimized out>)
    at /home/babis/Downloads/ror-dependencies/rigs-of-rods/source/main/GameContext.cpp:461
#3  0x00005555555ea592 in main (argc=<optimized out>, argv=<optimized out>)
    at /home/babis/Downloads/ror-dependencies/rigs-of-rods/source/main/main.cpp:843

introduced in #2692

makes sense because ar_engine may be nullptr for loads and stuff.

Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tritonas00 tritonas00 merged commit abebe86 into RigsOfRods:master Mar 5, 2021
@tritonas00 tritonas00 deleted the rev-net-fix branch March 5, 2021 22:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants