Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Repository Manager #2850

Merged
merged 5 commits into from
Mar 12, 2022
Merged

Repository Manager #2850

merged 5 commits into from
Mar 12, 2022

Conversation

tritonas00
Copy link
Collaborator

@tritonas00 tritonas00 commented Feb 8, 2022

An in game repository manager, thanks to the new upcoming API provided by @Zentro and the help of @only-a-ptr. Three view modes are available, categories, searching, sorting and the basic functionality of installing/updating and removing mods, in the mods folder.

kk1
kk2
kk3
kk4

Limitations

Currently the panel will detect/(re)install/update/remove mods only in the mods directory. We may refine in the future.

Closes #2450
Closes #229

@cryham
Copy link
Contributor

cryham commented Mar 7, 2022

Wow looks great.
I wanted to ask something. Sorry if off topic, but:
the only thing that I miss in here (and on forum/resources browser) is a license info like e.g. GPL, CC-BY-SA, etc.

I guess it is safe to assume that except for just 3 things (that are GPLed in https://github.com/RigsOfRods/content repo), all else has no license what-so-ever right? Meaning anybody can only download it and use in RoR right?
And likely nothing will change here, because that would require contacting authors (likely some left years ago) and asking them to specify and release their content with a license, like CC or so, and them agreeing. Also BTW some cars have textures with logos etc, which is not legal to use anyway or probably textures made from non-CC stuff etc which makes CC licensing impossible too.

@tritonas00
Copy link
Collaborator Author

tritonas00 commented Mar 11, 2022

Wow looks great. I wanted to ask something. Sorry if off topic, but: the only thing that I miss in here (and on forum/resources browser) is a license info like e.g. GPL, CC-BY-SA, etc.

I guess it is safe to assume that except for just 3 things (that are GPLed in https://github.com/RigsOfRods/content repo), all else has no license what-so-ever right? Meaning anybody can only download it and use in RoR right? And likely nothing will change here, because that would require contacting authors (likely some left years ago) and asking them to specify and release their content with a license, like CC or so, and them agreeing. Also BTW some cars have textures with logos etc, which is not legal to use anyway or probably textures made from non-CC stuff etc which makes CC licensing impossible too.

We will add this info in the panel

Creator of Stunt Rally

Just noticed, great respect!

Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few details I noticed and I think it's perfect now.

@tritonas00
Copy link
Collaborator Author

tritonas00 commented Mar 12, 2022

improved download speed/rem. time calc

welp now its off for me, both speed and remaining time
kk

my connection's max download speed in ~2MB/sec, speed/10 shows it correctly, i guess it depends on the connection

here is how curl does it https://github.com/curl/curl/blob/master/lib/progress.c#L389

maybe we should just remove speed and leave only downloaded MB of full filesize MB + a better remaining time and call it a day

@ohlidalp
Copy link
Member

welp now its off for me, both speed and remaining time

Thanks for the CURL link, I took another shot and I'm pretty confident it works right now. In both cases I coded & tested using jumpy wi-fi on train :)

maybe we should just remove speed and leave only downloaded MB of full filesize MB + a better remaining time and call it a day

Agreed. If you're still not happy with it, just erase my commit or do whatever edit you like, then merge this.

@tritonas00
Copy link
Collaborator Author

tritonas00 commented Mar 12, 2022

Yep, still problems with it. Lets go KISS

kk

@tritonas00 tritonas00 merged commit ec6b7d7 into RigsOfRods:master Mar 12, 2022
@tritonas00 tritonas00 deleted the repo branch March 12, 2022 23:07
@bippy89
Copy link

bippy89 commented Dec 15, 2022

wheres the download

@ohlidalp
Copy link
Member

@bippy89 wheres the download

https://www.rigsofrods.org/download

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content installation - user experience. Feature Request: Repository Downloads
4 participants