Fixed crash when reloading actor during race #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Race display in top menubar tries to access Actor which was already deleted. Cause: the top menubar is rendered in between removing the actor and updating the simbuffer, so it draws a dangling Actor pointer from the simbuffer. Broken by: 5472275 where the race display was moved to top menubar. Fix: Update simbuffer immediately after removing actor.
CuriousMike56
approved these changes
Dec 25, 2022
tritonas00
approved these changes
Dec 26, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on Discord by The Jesser#8202
Problem: Race display in top menubar tries to access Actor which was already deleted.
Cause: the top menubar is rendered in between removing the actor and updating the simbuffer, so it draws a dangling Actor pointer from the simbuffer.
Broken by: 5472275 where the race display was moved to top menubar.
Fix: Update simbuffer immediately after removing actor.