Skip to content

Unterminated C-style comment makes gccrs to never returns #300

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
dkm opened this issue Mar 20, 2021 · 0 comments · Fixed by #302
Closed

Unterminated C-style comment makes gccrs to never returns #300

dkm opened this issue Mar 20, 2021 · 0 comments · Fixed by #302
Labels
bug

Comments

@dkm
Copy link
Member

dkm commented Mar 20, 2021 

/*

This is enough to make gccrs hangs on Attempting to parse file:

I guess this could be an easy first PR?
@philberty philberty added the bug label Mar 20, 2021
dkm added a commit to dkm/gccrs that referenced this issue Mar 23, 2021
@dkm
WIP: Fix error while unexpected EOF when scanning for end of comment
586f7bf 
Returns EOF token and let parser handle the error.

fix Rust-GCC#300
dkm added a commit to dkm/gccrs that referenced this issue Mar 24, 2021
@dkm
WIP: Fix error while unexpected EOF when scanning for end of comment
79c8b65 
fix Rust-GCC#300
dkm added a commit to dkm/gccrs that referenced this issue Mar 24, 2021
@dkm
WIP: Fix error while unexpected EOF when scanning for end of comment
47298b6 
fix Rust-GCC#300
dkm added a commit to dkm/gccrs that referenced this issue Mar 24, 2021
@dkm
Fix error while unexpected EOF when scanning for end of comment
aa35f03 
Emit an error when EOF is reached before end of C-style comment.

fix Rust-GCC#300
dkm added a commit to dkm/gccrs that referenced this issue Mar 24, 2021
@dkm
Fix error while unexpected EOF when scanning for end of comment
f93c570 
Emit an error when EOF is reached before end of C-style comment.

fix Rust-GCC#300
@dkm dkm mentioned this issue Mar 24, 2021
Merged
dkm added a commit to dkm/gccrs that referenced this issue Mar 24, 2021
@dkm
Fix error while unexpected EOF when scanning for end of comment
169003d 
Emit an error when EOF is reached before end of C-style comment.
Add corresponding test for non regression.

fix Rust-GCC#300
dkm added a commit to dkm/gccrs that referenced this issue Mar 26, 2021
@dkm
Fix error while unexpected EOF when scanning for end of comment
b97f145 
Emit an error when EOF is reached before end of C-style comment.
Add corresponding test for non regression.

fix Rust-GCC#300
philberty pushed a commit that referenced this issue Mar 27, 2021
@dkm @philberty
Fix error while unexpected EOF when scanning for end of comment
e77c44e 
Emit an error when EOF is reached before end of C-style comment.
Add corresponding test for non regression.

fix #300
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error while unexpected EOF when scanning for end of comment dkm/gccrs
2 participants
@philberty @dkm