Fix error while unexpected EOF when scanning for end of comment #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
approved these changes
Mar 24, 2021
|
Before this is merged can you add a test case for this? |
|
of course. I have one locally that uses my other changes, but I can still add one in the current tests ! |
|
Test added :) |
Emit an error when EOF is reached before end of C-style comment. Add corresponding test for non regression. fix Rust-GCC#300
dkm
added a commit
to dkm/gccrs
that referenced
this pull request
Mar 27, 2021
the PR Rust-GCC#302 and Rust-GCC#301 were conflicting because they are both modifying the tests. Move the conflicting test and add correct dg-error directive.
dkm
added a commit
to dkm/gccrs
that referenced
this pull request
Mar 27, 2021
the PR Rust-GCC#302 and Rust-GCC#301 were conflicting because they are both modifying the tests. Move the conflicting test and add correct dg-error directive. continue1.rs is less verbose after Rust-GCC#286, remove the dg-excess-error.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit an error when EOF is reached before end of C-style comment.
fix #300