Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(platform): add cellActivate event to platform table #11875

Merged
merged 1 commit into from
May 7, 2024

fix(platform): add cellActivate event to platform table

dc6313c
Select commit
Loading
Failed to load commit list.
Merged

fix(platform): add cellActivate event to platform table #11875

fix(platform): add cellActivate event to platform table
dc6313c
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed May 3, 2024 in 0s

1/3 Fail(s): APPROVALS

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must exclude '^[WIP]'
    Input : fix(platform): add cellActivate event to platform table
    Settings : {"must_exclude":{"regex":"^\\[WIP\\]","message":"This is work in progress. Do not merge yet."}}
  • ✔️ title must include '^(feat|docs|chore|fix|test)((\w+))?(:|().+$'
    Input : fix(platform): add cellActivate event to platform table
    Settings : {"must_include":{"regex":"^(feat|docs|chore|fix|test)(\\(\\w+\\))?(:|\\().+$","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '[ ]'
    Input : fixes #11639

Decided to piggyback on the rowActivate event. This works similarly, it just passes columnIndex instead of the row index. Also, row does not need to be activable. WIP because I am open to name suggestions
Settings : {"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}

❌ Validator: APPROVALS

  • (approvals: InnaAtanasova required OR approvals: droshev required OR approvals: N1XUS required OR approvals: g-cheishvili required OR approvals: platon-rov required OR approvals: mikerodonnell89 required OR approvals count is less than "2")
    Input :
    Settings : {"or":[{"required":{"reviewers":["InnaAtanasova"]}},{"required":{"reviewers":["droshev"]}},{"required":{"reviewers":["N1XUS"]}},{"required":{"reviewers":["g-cheishvili"]}},{"required":{"reviewers":["platon-rov"]}},{"required":{"reviewers":["mikerodonnell89"]}},{"min":{"count":2}}]}