[Fix] 관심장르 empty인 경우 separator 위치 조정 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
관심 장르 empty인 경우 label에 " " 넣어줘 라벨 크기 갖도록 해 separator 위치 조정
|
" "을 넣어서 해결하는 게 방법보다는 UI 자체를 수정하는 방법이 좋을 것 같습니다! 나중에 히스토리를 모르는 누군가가 봤을 땐 왜 이렇게 짰는지 모를 수 있어서요 |
minHeight = genreLabel height + top inset + bottom inset
|
수정했습니다! |
seungwon-yoo
approved these changes
Jul 15, 2023
JongHoooon
added a commit
that referenced
this pull request
Jul 17, 2023
* [Fix] 관심장르 empty인 경우 separator 위치 조정 관심 장르 empty인 경우 label에 " " 넣어줘 라벨 크기 갖도록 해 separator 위치 조정 * [fix] genreView의 최소 높이 constraint 추가 minHeight = genreLabel height + top inset + bottom inset
JongHoooon
added a commit
that referenced
this pull request
Jul 17, 2023
* [Fix] 관심장르 empty인 경우 separator 위치 조정 관심 장르 empty인 경우 label에 " " 넣어줘 라벨 크기 갖도록 해 separator 위치 조정 * [fix] genreView의 최소 높이 constraint 추가 minHeight = genreLabel height + top inset + bottom inset
JongHoooon
added a commit
that referenced
this pull request
Jul 17, 2023
* [Fix] 관심장르 empty인 경우 separator 위치 조정 관심 장르 empty인 경우 label에 " " 넣어줘 라벨 크기 갖도록 해 separator 위치 조정 * [fix] genreView의 최소 높이 constraint 추가 minHeight = genreLabel height + top inset + bottom inset
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관심 장르 empty인 경우 label에 " " 넣어줘 라벨 크기 갖도록 해 separator 위치 조정
#139