Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Fix] 관심장르 empty인 경우 separator 위치 조정 #140

Merged
merged 2 commits into from
Jul 15, 2023
Merged

[Fix] 관심장르 empty인 경우 separator 위치 조정 #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef501e
[Fix] 관심장르 empty인 경우 separator 위치 조정
JongHoooon Jul 13, 2023
ac60ded
[fix] genreView의 최소 높이 constraint 추가
JongHoooon Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sinzak/Scene/MyProfile/EditProfile/VC/EditProfileVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ final class EditProfileVC: SZVC {
let genres: String = genres
.map { $0.text }
.joined(separator: "\n")

owner.mainView.genreNameLabel.text = genres
})
.disposed(by: disposeBag)
Expand Down
14 changes: 6 additions & 8 deletions Sinzak/Scene/MyProfile/EditProfile/View/EditProfileView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ final class EditProfileView: SZView {
.joined(separator: "\n")

genreNameLabel.text = categoryLike

applyAuthorButton.isEnabled = !profile.certAuthor
applyAuthorButton.isEnabled = !profile.certAuthor
}

// MARK: - Design Helpers
Expand Down Expand Up @@ -337,22 +337,20 @@ final class EditProfileView: SZView {
make.height.equalTo(0.5)
}
genreView.snp.makeConstraints { make in
let minHeight = 16.0 + 19.0 + 19.0

make.leading.trailing.equalToSuperview()
make.bottom.equalTo(genreNameLabel.snp.bottom).offset(20.0)
make.height.greaterThanOrEqualTo(minHeight)
}
genreLabel.snp.makeConstraints { make in
make.leading.top.equalToSuperview().inset(19)
}
genreNameLabel.snp.makeConstraints { make in
make.top.equalTo(genreLabel)
make.leading.equalTo(genreLabel.snp.trailing).offset(30)
make.trailing.lessThanOrEqualTo(changeGenreButton.snp.leading).offset(-10)
make.trailing.equalTo(changeGenreButton.snp.leading).offset(-10)
}
genreNameLabel.setContentCompressionResistancePriority(
.defaultLow,
for: .horizontal
)

changeGenreButton.snp.makeConstraints { make in
make.trailing.equalToSuperview().inset(24)
make.width.equalTo(72)
Expand Down