removed FA from project; updagraded to latest normalize #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @pookmish |
|
This looks good to me. @JBCSU & @AlishaOber This also updates to the latest version of normalize.css. Please have a review and let me know if there are any issues with these changes. |
sherakama
approved these changes
Apr 20, 2018
|
@josephgknox looks like some conflicts in this now. |
|
@pookmish yeah, thanks for keeping your eyes on this. We had merged in another branch off of master that still have the legacy stuff in there (since this one has not been merged). I've resolved the conflicts. |
|
Wonderful. Thank you. |
josephgknox
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Quote tweaks (#105) * Created quote element within elements directory based on design Kerri made for the Engineering project * tweak Quote template to make it easier to include directly into themes * don't hardcode path to quote's image * update neat-omega, grunt, grunt-sass, jquery, and associated dependencies (#106) * #107 specify node version (#108) * removed FA from project; updagraded to latest normalize (#101)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People
See Also