Quote tweaks #105
Merged
Quote tweaks #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… made for the Engineering project
* master: Quote element (#100) # Conflicts - all resolved "using theirs": # css/decanter.css # styleguide/item-elements-quote.html # styleguide/section-elements.html # templates/elements/quote/quote.html.json # templates/elements/quote/quote.html.twig
sherakama
requested changes
Apr 23, 2018
| @@ -1,8 +1,8 @@ | |||
| <div class="decanter-quote"> | |||
| <img class="decanter-quote__img " src="../../../img/circle.png" alt="Please provide alt text"> | |||
| <img class="decanter-quote__img " src="../../../img/{{ image }}" alt="{{ altText }}"> | |||
There was a problem hiding this comment.
@JBCSU Let's change the src attribute to src="{{ image }}" so we can supply full paths to this template instead of assuming ../../../img/
|
Yes, of course. Great point! |
sherakama
approved these changes
Apr 23, 2018
|
Looks great! |
josephgknox
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Quote tweaks (#105) * Created quote element within elements directory based on design Kerri made for the Engineering project * tweak Quote template to make it easier to include directly into themes * don't hardcode path to quote's image * update neat-omega, grunt, grunt-sass, jquery, and associated dependencies (#106) * #107 specify node version (#108) * removed FA from project; updagraded to latest normalize (#101)
sherakama
pushed a commit
that referenced
this pull request
Apr 30, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few changes to the
quote.html.twigtemplate to make it easier to use directly in a theme. Specifically, I'm using variables for the path to the image and to the image alt text, rather than hardcoding those.I also renamed the
.decanter-quote__detailclass to.decanter-quote__bioto make it (hopefully!) clearer that the detail pertained to the person being quoted, not the quote itself.