Adding package.json file #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherakama
commented
Jan 20, 2017
| "dependencies": { | ||
| "bourbon": "~5.0.0-beta.7", | ||
| "bourbon-neat": "^2.0.0-beta.2", | ||
| "font-awesome": "^4.6.3" |
There was a problem hiding this comment.
I can go both ways on adding this or not.
There was a problem hiding this comment.
These should be devDependencies, rather than dependencies, since there is no runtime. I believe this will fetch those projects into node-modules, which may end up throwing conflicts if the root project uses different versions. We should test this.
There was a problem hiding this comment.
I think we do want the version conflicts. If we are using bourbon 2.0 and someone is using the ~1.0 version in their app then they won't be able to compile or they will have errors. I think any version conflict from declaring these as dependencies is a helpful error.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review