Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding package.json file #2

Merged
merged 1 commit into from
Jan 21, 2017
Merged

Adding package.json file #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"bugs": {
"url": "https://github.com/su-sws/decanter/issues"
},
"description": "A collection of SCSS patterns for theme development.",
"homepage": "https://github.com/su-sws/decanter",
"keywords": [
"css",
"mixins",
"sass",
"scss"
],
"license": "GPLV2",
"name": "decanter",
"repository": {
"type": "git",
"url": "https://github.com/su-sws/decanter.git"
},
"version": "0.1.0",
"dependencies": {
"bourbon": "~5.0.0-beta.7",
"bourbon-neat": "^2.0.0-beta.2",
"font-awesome": "^4.6.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can go both ways on adding this or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be devDependencies, rather than dependencies, since there is no runtime. I believe this will fetch those projects into node-modules, which may end up throwing conflicts if the root project uses different versions. We should test this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do want the version conflicts. If we are using bourbon 2.0 and someone is using the ~1.0 version in their app then they won't be able to compile or they will have errors. I think any version conflict from declaring these as dependencies is a helpful error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me!

}
}