Create Aspect Ratio Mixin #445
Conversation
|
@rebeccahongsf I will take this over for now. :) |
…ntly does not appear on site.
|
@rebeccahongsf @sherakama Hey there - just want to check in and see what's the status of this PR 😄 We could use this mixin for the media field component (will be used in cards). Let me know if I could help with reviewing etc. |
…ntly does not appear on site.
…m/SU-SWS/decanter into 310-aspect-ratio-container-mixins
|
If you need this in your work feel free to merge it into your working branch. |
|
I took a stab at cleaning up the branch and merging it with the latest work from the master branch. I also moved a couple of things around and deleted the duplicate example template. Please let me know if this makes sense as I wasn't 100% sure what the desired outcome was supposed to be. |
…ey don't get distorted; mixin directory name change
|
@rebeccahongsf @sherakama - I did some touch up and added 3 use cases in the example section (Core -> Helpers -> Aspect Ratio Container). Please let me know what you think. |
|
Thanks! Looks great. |
* master: (28 commits) Updated packages and configuration files. (#527) Use rem instead of em for big button font size so it doesn't blow up in sections if we set a large base font size; finetune big button padding for smaller breakpoints (#522) Change sizes of link icons to use px instead of em to prevent occasional clipping (#523) D8CORE-628: Add caption option to hero banner. (#517) Use percentage for html root font size instead of px so people can scale up using browser font size preferences (#526) Mixins documention update — @centered-column (#448) Adds Tugboat and fixes npm dependencies. (#518) Update _hero.scss (#513) Create Aspect Ratio Mixin (#445) Adding global footer variants and link tweaks for legibility, change layout at MD breakpoint to match Figma (#500) Updated package and lock files. Add parameter to @link-icon to adjust vertical position of icon and different options for $animate parameter (#504) Delete card-2019-08-28.twig (#506) Update _input.scss (#507) Scale down type-a and type-b font size at xs and sm breakpoints, repurpose splash font and minor typography tweaks (#498) Add 4 new @modular-spacing steps (#6 to #9) and modify 2 existing steps (#3 and #4) (#503) add su- prefix to Decanter core and component variables, deprecate old names (#452) Includevar (#496) Put appearance back for select dropdowns (#479) Split input.scss into several files and add new input-base placeholder (#476) ... # Conflicts (resolved manually) # core/dist/css/decanter.css # core/src/scss/components/card/_card.scss # core/src/scss/components/card/index.scss # core/src/scss/utilities/placeholders/components/_card.scss # core/src/templates/components/card/card.twig
NOT READY
To Do:
Summary
Needed By (Date)
N/A
Urgency
N/A
Steps to Test
Affected Projects or Products
Associated Issues and/or People
See Also