Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update _hero.scss #513

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Update _hero.scss #513

merged 2 commits into from
Oct 16, 2019

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Oct 16, 2019

READY FOR REVIEW/

Summary

  • hides overflow of images larger than the max height of the banner.
  • Don't render an empty card wrapper when no card content is provided.

Review By (Date)

  • October 22

Urgency

  • Low, but it is a bug.

Steps to Test

  1. Modify the test image for the hero banner to be 1000px tall
  2. Compile the styleguide and see the overflow
  3. check out this branch
  4. Compile the styleguide and see the image overflow as hidden
  5. Win.

Affected Projects or Products

  • D8CORE
  • Wordpress theme.

Associated Issues and/or People

See Also

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG!

@sherakama sherakama merged commit a0a4ac5 into master Oct 16, 2019
@sherakama sherakama deleted the sherakama-patch-1 branch October 16, 2019 18:51
@sherakama
Copy link
Member Author

Thank you.

yvonnetangsu added a commit that referenced this pull request Oct 16, 2019
* master:
  Update _hero.scss (#513)
  Create Aspect Ratio Mixin (#445)

# Conflicts (resolved manually)
#	kss/builder/decanter/kss-assets/css/kss.css
#	kss/builder/decanter/scss/_aspect-ratio.scss
yvonnetangsu added a commit that referenced this pull request Oct 29, 2019
* master: (28 commits)
  Updated packages and configuration files. (#527)
  Use rem instead of em for big button font size so it doesn't blow up in sections if we set a large base font size; finetune big button padding for smaller breakpoints (#522)
  Change sizes of link icons to use px instead of em to prevent occasional clipping (#523)
  D8CORE-628: Add caption option to hero banner. (#517)
  Use percentage for html root font size instead of px so people can scale up using browser font size preferences (#526)
  Mixins documention update — @centered-column (#448)
  Adds Tugboat and fixes npm dependencies. (#518)
  Update _hero.scss (#513)
  Create Aspect Ratio Mixin (#445)
  Adding global footer variants and link tweaks for legibility, change layout at MD breakpoint to match Figma (#500)
  Updated package and lock files.
  Add parameter to @link-icon to adjust vertical position of icon and different options for $animate parameter (#504)
  Delete card-2019-08-28.twig (#506)
  Update _input.scss (#507)
  Scale down type-a and type-b font size at xs and sm breakpoints, repurpose splash font and minor typography tweaks (#498)
  Add 4 new @modular-spacing steps (#6 to #9) and modify 2 existing steps (#3 and #4) (#503)
  add su- prefix to Decanter core and component variables, deprecate old names (#452)
  Includevar (#496)
  Put appearance back for select dropdowns (#479)
  Split input.scss into several files and add new input-base placeholder (#476)
  ...

# Conflicts (resolved manually)
#	core/dist/css/decanter.css
#	core/src/scss/components/card/_card.scss
#	core/src/scss/components/card/index.scss
#	core/src/scss/utilities/placeholders/components/_card.scss
#	core/src/templates/components/card/card.twig
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants