Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Update Codacy Badge #2147

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Update Codacy Badge #2147

merged 5 commits into from
Sep 13, 2022

Conversation

hessio
Copy link
Contributor

@hessio hessio commented Aug 8, 2022 •
edited
Loading

Resolves issue #1528

Signed-off-by: hessio patrick.hession@seagate.com

Signed-off-by: Patrick Hession patrick.hession@seagate.com

View rendered README.md

@hessio
Update Codacy Badge
bcd5d50 
Resolves (issue #1528)[Seagate/cortx#1528]

Signed-off-by: hessio <patrick.hession@seagate.com>

Signed-off-by: Patrick Hession <patrick.hession@seagate.com>
@cla-bot cla-bot bot added the cla-signed label Aug 8, 2022
@hessio hessio added the Status: Waiting to be Reviewed PR needs to be reviewed label Aug 8, 2022
@stale
Copy link

stale bot commented Aug 16, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 6 days. Tagging @mssawant for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@mssawant
Copy link

@hessio, can you elaborate a more about the problem and the fix? why codacy badge was wrong and how this PR fixes it?

@hessio
Copy link
Contributor Author

hessio commented Aug 23, 2022

@hessio, can you elaborate a more about the problem and the fix? why codacy badge was wrong and how this PR fixes it?

Yes sure I can elaborate - Codacy Badge is not rendering correctly on the HARE README - see below:

I updated the Codacy Badge link from the Codacy app to fix the error.

@mssawant
Copy link

Thanks @hessio, in general it is good practice to have a clear commit message to understand the problem and the fix. It is evident that codacy badge was not rendering but it is good to elaborate why the badge stopped rendering or was it not rendering from the start itself. And what was actually missing and how we fixed this problem. Was there some update to the badge and do we need to look into this periodically or was it that we missed something from our side.

@hessio
Copy link
Contributor Author

hessio commented Aug 25, 2022

Thanks @hessio, in general it is good practice to have a clear commit message to understand the problem and the fix. It is evident that codacy badge was not rendering but it is good to elaborate why the badge stopped rendering or was it not rendering from the start itself. And what was actually missing and how we fixed this problem. Was there some update to the badge and do we need to look into this periodically or was it that we missed something from our side.

I am not sure what caused the issue - to fix the issue I just went to the Codacy dashboard and copy/pasted the link to the Codacy Badge for this repo.

@stale stale bot removed the needs-attention label Sep 2, 2022
@hessio
Copy link
Contributor Author

hessio commented Sep 12, 2022

@mssawant can we merge this PR?

@d-nayak d-nayak merged commit 7e9dea9 into main Sep 13, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@vaibhavparatwar vaibhavparatwar vaibhavparatwar approved these changes

@pavankrishnat pavankrishnat pavankrishnat approved these changes

@d-nayak d-nayak d-nayak approved these changes

@Shreya-18 Shreya-18 Awaiting requested review from Shreya-18

@mssawant mssawant Awaiting requested review from mssawant

Assignees

@mssawant mssawant

@vaibhavparatwar vaibhavparatwar

@Shreya-18 Shreya-18

@d-nayak d-nayak

Labels
cla-signed Status: Waiting to be Reviewed PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codacy Badge is not rendering properly for five docs
6 participants
@hessio @mssawant @vaibhavparatwar @pavankrishnat @d-nayak @Shreya-18