Skip to content

determine background or extension page by this #220

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

reorx
Copy link

@reorx reorx commented Mar 16, 2022

Checklist

  • I ran the linting and formatting tools (ESLint and Prettier)
  • I added addittional tests if adding new features

Closes #28

pass this instead of window into the injection anonymous function, use window.document to determine whether this is window or not, which also infers whether the page is background or extension.

@rushilsrivastava
Copy link
Member

Amazing, thanks! I have a few minor changes, do you mind if I commit on your branch?

@reorx
Copy link
Author

reorx commented Mar 17, 2022 via email

@just-jeb just-jeb mentioned this pull request Jun 30, 2022
2 tasks
@reorx reorx force-pushed the fix-background-page branch from bc82c99 to 6368933 Compare January 10, 2023 14:27
@vialoh
Copy link
Collaborator

vialoh commented Sep 28, 2023

Closing in favor of #386.

@vialoh vialoh closed this Sep 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MV3 Support?
3 participants