-
Notifications
You must be signed in to change notification settings - Fork 31
fix: support mv3 background script #222
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Hi! Any movement on getting this PR in master? Thanks :D |
Hey! I'm looking for this as well, can it be merged? |
Hi @rushilsrivastava @rubenspgcavalcante could you help to review this PR? |
I've tried both this patch and #220, none of them seem to be working. Getting |
that's really odd -- it works in our fork. could you try that and see? |
Sorry for the hiatus - happy to help get this merged in.
Any reproducible examples? |
@iantanwx @rushilsrivastava are your forks up to date with master? What I did essentially is taking these patches and applying them on a latest local version of |
@iantanwx Were you able to reproduce this? |
@rushilsrivastava Sorry I have been really busy, have not rebased upstream yet. Will try to do this in the coming week. Apologies! |
Hi @iantanwx any news on this? |
I can give you a clue to how to solve this issue. browser.runtime should be replaced with chrome.runtime in manifest 3. it is better to remove 'webextension-polyfill' |
This fixes `browser` is undefined which should be caused by webextension-polyfill's bad support for MV3 see: SimplifyJobs#222
I adapted @sherifmayika 's advice and finally made my fork work. Anyone with the same problem can try to use my fork at https://github.com/reorx/webpack-ext-reloader |
Perfect, I'll take a look at the PR @reorx! |
Closing in favor of #386. |
Fixes background worker issues in manifest version 3. See rubenspgcavalcante/webpack-extension-reloader#139.
Checklist
Closes #[ISSUE_NUMBER]