seat/pointer: simplify ThemedPointer handling #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
commented
May 5, 2023
kchibisov
force-pushed
the
themed-pointer-change
branch
from
8cecd26 to
79927ac
Compare
|
I've converted to draft to wait for stable release of The mentioned crate is shared with @i509VCB , so smithay folks have access to it as well. I do wonder whether we should maintain fallback lists like we have in winit or simply rely on w3c icon names, from my testing just using w3c icon names worked fine, but I'm not sure how it'll work with weird themes. |
kchibisov
force-pushed
the
themed-pointer-change
branch
from
79927ac to
bb487fe
Compare
|
I've updated the Now you can press |
kchibisov
force-pushed
the
themed-pointer-change
branch
from
bb487fe to
b75b0b4
Compare
kchibisov
force-pushed
the
themed-pointer-change
branch
from
b75b0b4 to
b2e97f4
Compare
kchibisov
commented
May 9, 2023
|
This should be ready for review now. |
kchibisov
force-pushed
the
themed-pointer-change
branch
from
b2e97f4 to
6348dd3
Compare
This should simplify the handling of custom cursors in the user applications by incapsulating all the necessary state in the ThemedPointer. The new cursor-icon crate for better compatibility across the ecosystem, so the icon could be passed as is. In the future we can automatically handle the `wp_cursor_shape` under the hood.
kchibisov
force-pushed
the
themed-pointer-change
branch
from
6348dd3 to
26fe07a
Compare
wash2
approved these changes
May 16, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should simplify the handling of custom cursors in the user applications by incapsulating all the necessary state in the ThemedPointer.
In the future we can automatically handle the
wp_cursor_shapeunder the hood.