-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
cursor-icon version 1.0.0 #2
Conversation
Let's add a no-op [features]
default = ["std"]
std = ["alloc"]
alloc = [] // For forwards compatibility
#[cfg(feature = "alloc")]
extern crate alloc as _; |
Haven't noticed your link. |
Adding aliases is not justified, see https://www.freedesktop.org/wiki/Specifications/cursor-spec/ . There's a movement to use standard icon names, so we can keep everything the way it is. And most cursor themes have all the variants listed in that spec already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the API Guidelines Checklist and made PRs for the things I found missing. Aside from that, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I'll mention this from matrix given that went into legal off topic: Should we include documentation for CursorIcon::from_str to specify what string values are expected. I'd guess it's the CSS values from quickly searching? |
Done in 92dd3e6 |
--
r @i509VCB @notgull ?