Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

HETZNER: Enable cmode concurrent #3206

Closed

Conversation

willpower232
Copy link
Contributor

As per #3202, I believe Hetzner works with concurrency

@tlimoncelli
Copy link
Contributor

CC @das7pad (provider owner)

Looking at the code, this should work fine.

If you'd like to verify empirically, please do the following:

  1. Compile with the -race flag: go install -race
  2. Run with a dnsconfig.js that has multiple domains from this provider (4 or more is preferable)
  3. Run "dnscontrol preview --cmode concurrent` two or three times. You should get zero race condition errors

@tlimoncelli
Copy link
Contributor

@das7pad ok with this change? I'd like to include this in the next release.

@das7pad
Copy link
Contributor

das7pad commented Dec 10, 2024

Hi! Sorry for the delay in getting back to you. I've opened #3234 with the necessary changes to make the provider thread-safe.

@willpower232 willpower232 deleted the hetzner-can-concur branch December 12, 2024 17:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants