HETZNER: enable concurrency capability #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
|
I'm presuming you have already run this against your accounts so let me know if you'd like me to run it as well, otherwise thanks for making it even better 😎 |
|
Yes, the integration tests are passing on a scratch domain. |
|
Thanks so much! Excellent mutex'ing!!! Best, |
tlimoncelli
added a commit
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Jakob Ackermann <das7pad@outlook.com> Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
tlimoncelli
added a commit
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Jakob Ackermann <das7pad@outlook.com> Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3206
This PR is making the Hetzner provider thread-safe and enabling the concurrency feature flag.
I've tweaked the rate-limiting to play better with concurrency by not overshooting the rate-limit reset point.
cc @tlimoncelli @willpower232