Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Behat][Promotion] Percentage discount scenarios implementation #4234

Conversation

Zales0123
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Doc PR

PR based on #4208 and #4176.
Implementation of percentage discount scenarios.

@Zales0123 Zales0123 changed the title Percentage discount promotion scenarios [Behat][Promotion] Percentage discount promotion scenarios Feb 19, 2016
@Zales0123 Zales0123 changed the title [Behat][Promotion] Percentage discount promotion scenarios [Behat][Promotion] Percentage discount scenarios implementation Feb 19, 2016
@michalmarcinkowski michalmarcinkowski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 19, 2016
@Zales0123 Zales0123 force-pushed the percentage-discount-promotion-scenarios branch 4 times, most recently from ec96ee0 to 1a71816 Compare February 22, 2016 06:39
*/
private function getPercentageFromString($discount)
{
return ((int) $discount)/100;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

((int) $discount) / 100

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Zales0123 Zales0123 force-pushed the percentage-discount-promotion-scenarios branch from 1a71816 to 52ec41a Compare February 22, 2016 12:43
michalmarcinkowski added a commit that referenced this pull request Feb 22, 2016
…-scenarios

[Behat][Promotion] Percentage discount scenarios implementation
@michalmarcinkowski michalmarcinkowski merged commit 3518aef into Sylius:master Feb 22, 2016
@michalmarcinkowski
Copy link
Contributor

👍

@Zales0123 Zales0123 deleted the percentage-discount-promotion-scenarios branch October 28, 2016 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants