Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Siemens Vision600 Hoffman #127

Merged
merged 13 commits into from
Oct 10, 2024
Merged

Siemens Vision600 Hoffman #127

merged 13 commits into from
Oct 10, 2024

Conversation

KrisThielemans
Copy link
Member

No description provided.

@KrisThielemans KrisThielemans added enhancement New feature or request data labels Oct 9, 2024
@KrisThielemans KrisThielemans self-assigned this Oct 9, 2024
casperdcl
casperdcl requested changes Oct 9, 2024
View reviewed changes
KrisThielemans and others added 2 commits October 9, 2024 14:54
@KrisThielemans @casperdcl
argument processing improvements
0436d4d 
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
@KrisThielemans
print settings and add updates option for run_OSEM
5b86e1a
@KrisThielemans KrisThielemans force-pushed the Siemens_Vision600_Hoffman branch 2 times, most recently from 106510b to 5894c4c Compare October 9, 2024 21:28
@KrisThielemans
handle interval option in MetricsWithTimeout
4d49f88
@KrisThielemans
run_OSEM/BSREM: reduce frequency of metric/saving callback
5ffed5f 
Callbacks (and hence run_OSEM/BSREM) used to save images
when objective functions were computed. Now this has a separate
keyword, so use that.
@KrisThielemans KrisThielemans force-pushed the Siemens_Vision600_Hoffman branch from 5894c4c to 5ffed5f Compare October 9, 2024 23:23
@KrisThielemans KrisThielemans merged commit 0f79b70 into SyneRBI:main Oct 10, 2024
1 check passed
@KrisThielemans KrisThielemans deleted the Siemens_Vision600_Hoffman branch October 10, 2024 10:07
@KrisThielemans
Copy link
Member Author

I first ran 10000 updates, but that didn't feel safe enough, so continued with smaller stepsize

python -m SIRF_data_preparation.run_BSREM Siemens_Vision600_Hoffman --updates=10000
python -m SIRF_data_preparation.run_BSREM Siemens_Vision600_Hoffman --updates=6000 --initial_image=output/Siemens_Vision600_Hoffman/BSREM/iter_final.hv --initial_step_size=.01 --relaxation_eta=.03

Pass index is 7680 (was close to that when using image at 10000 updates as reference)

objectives

Note jump after 10000 due to restart
Siemens_Vision600_Hoffman_BSREM_objectives
Siemens_Vision600_Hoffman_BSREM_objectives_last

metrics

Siemens_Vision600_Hoffman_metrics_BSREM
Siemens_Vision600_Hoffman_metrics_BSREM_cont
Siemens_Vision600_Hoffman_metrics_BSREM_OSEM

"pass" images

Siemens_Vision600_Hoffman_image_at_0 01_0 005
diff with ref
Siemens_Vision600_Hoffman_ref_diff_image_at_0 01_0 005

@casperdcl casperdcl mentioned this pull request Oct 11, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@casperdcl casperdcl casperdcl requested changes

Assignees

@KrisThielemans KrisThielemans

Labels
data enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrisThielemans @casperdcl