Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add Vision600_Hoffman #132

Merged
merged 1 commit into from
Oct 14, 2024
Merged

add Vision600_Hoffman #132

merged 1 commit into from
Oct 14, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Oct 11, 2024

@casperdcl casperdcl self-assigned this Oct 11, 2024
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go of course, aside form the name choice.

@@ -312,7 +312,9 @@ def get_image(fname):
(SRCDIR / "Mediso_NEMA_IQ", OUTDIR / "Mediso_NEMA",
[MetricsWithTimeout(outdir=OUTDIR / "Mediso_NEMA", **DATA_SLICES['Mediso_NEMA_IQ'])]),
(SRCDIR / "GE_DMI3_Torso", OUTDIR / "DMI3_Torso",
[MetricsWithTimeout(outdir=OUTDIR / "DMI3_Torso", **DATA_SLICES['GE_DMI3_Torso'])])]
[MetricsWithTimeout(outdir=OUTDIR / "DMI3_Torso", **DATA_SLICES['GE_DMI3_Torso'])]),
(SRCDIR / "Siemens_Vision600_Hoffman", OUTDIR / "Vision600_Hoffman",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(SRCDIR / "Siemens_Vision600_Hoffman", OUTDIR / "Vision600_Hoffman",
(SRCDIR / "Siemens_Vision600_Hoffman", OUTDIR / "Siemens_Vision600_Hoffman",

I think in general it'd be far more sensible to use the same name all the time.

@casperdcl casperdcl merged commit c73598f into main Oct 14, 2024
3 checks passed
@casperdcl casperdcl deleted the Vision600_Hoffman branch October 14, 2024 12:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants