Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Listening activity type in Discord RPC #1350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brunohpaiva
Copy link
Contributor

Discord added support for different activity types some time ago, but Tauon still uses the "Playing" activity type:

image image

pypresence got support for it on August 2024, but the latest pypi release (4.3.0, from 2023) is outdated.

This PR implements it, fetching pypresence via Git.

image image

@C0rn3j
Copy link
Collaborator

C0rn3j commented Dec 18, 2024

I've pinged upstream about a release, last time they got back to it in a couple days, but it is holiday season at the moment...

qwertyquerty/pypresence#224

LGTM, but I'd wait a bit first to see if pypresence upstream won't package something up so we don't have to rely on git.

@C0rn3j
Copy link
Collaborator

C0rn3j commented Jan 3, 2025

Could you revert the requirements changes?

Looks like upstream will do a release shortly.

EDIT: Actually I suppose we want to do pypresence>=4.4.0 both for extra/requirements_optional.txt and requirements.txt after rebasing against current master

EDIT2: Thanks, now it's just waiting on qwertyquerty/pypresence#248 to be merged and release tagged

@brunohpaiva brunohpaiva force-pushed the brunohpaiva/discord-activity-type branch from 17fc694 to 23e136a Compare January 4, 2025 00:27
@C0rn3j C0rn3j added the blocked An issue from another project is preventing this from moving label Jan 4, 2025
@brunohpaiva brunohpaiva force-pushed the brunohpaiva/discord-activity-type branch from 23e136a to 25886b3 Compare February 14, 2025 20:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
blocked An issue from another project is preventing this from moving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants